Bug 172220

Summary:

[Readable Streams API] Align getDesiredSize with spec

Product:

WebKit

Reporter:

Romain Bellessort <romain.wkt>

Component:

WebCore Misc.

Assignee:

Romain Bellessort <romain.wkt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, nael.ouedp, rniwa, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Patch	none

Romain Bellessort

Reported 2017-05-17 08:17:32 PDT

Compared to current implementation, getDesiredSize operation for both controllers (ReadableStreamDefaultController and ReadableByteStreamController) has been updated. Hence, WPT tests do not pass.

Attachments
Patch (9.78 KB, patch) 2017-05-17 08:34 PDT, Romain Bellessort	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.09 MB, application/zip) 2017-05-17 12:14 PDT, Build Bot	no flags	Details
Patch (9.80 KB, patch) 2017-05-18 00:44 PDT, Romain Bellessort	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Romain Bellessort

Comment 1 2017-05-17 08:34:29 PDT

Created attachment 310393 [details] Patch

Chris Dumez

Comment 2 2017-05-17 10:24:55 PDT

Comment on attachment 310393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310393&action=review r=me. Thank you for the spec links. > Source/WebCore/ChangeLog:9 > + - https://streams.spec.whatwg.org/#readable-stream-default-controller-get-desired-size; Extra ; at the end.

Build Bot

Comment 3 2017-05-17 12:14:48 PDT

Comment on attachment 310393 [details] Patch Attachment 310393 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3764085 New failing tests: http/tests/appcache/404-resource-with-slow-main-resource.php

Build Bot

Comment 4 2017-05-17 12:14:49 PDT

Created attachment 310424 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Romain Bellessort

Comment 5 2017-05-18 00:44:09 PDT

Created attachment 310494 [details] Patch

WebKit Commit Bot

Comment 6 2017-05-18 05:56:49 PDT

Comment on attachment 310494 [details] Patch Clearing flags on attachment: 310494 Committed r217044: <http://trac.webkit.org/changeset/217044>

WebKit Commit Bot

Comment 7 2017-05-18 05:56:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.