Bug 172211

Summary:

Speedometer: adjust Ember TodoMVC to use full path

Product:

WebKit

Reporter:

Addy Osmani <addyo>

Component:

Tools / Tests

Assignee:

Addy Osmani <addyo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, lforschler, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

170513

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews100 for mac-elcapitan	none

Addy Osmani

Reported 2017-05-17 01:46:25 PDT

Per request from @rniwa, this change switches the path for the Ember TodoMVC app to include the full filename and extension. This will make it work using file:// on Safari too.

Attachments
Patch (1.34 KB, patch) 2017-05-17 01:47 PDT, Addy Osmani	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.08 MB, application/zip) 2017-05-17 03:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (12.41 MB, application/zip) 2017-05-17 03:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-elcapitan (1.08 MB, application/zip) 2017-05-17 07:44 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Addy Osmani

Comment 1 2017-05-17 01:47:39 PDT

Created attachment 310359 [details] Patch

Build Bot

Comment 2 2017-05-17 03:00:08 PDT

Comment on attachment 310359 [details] Patch Attachment 310359 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3760460 New failing tests: http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html

Build Bot

Comment 3 2017-05-17 03:00:09 PDT

Created attachment 310368 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-05-17 03:22:36 PDT

Comment on attachment 310359 [details] Patch Attachment 310359 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3760557 New failing tests: http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html

Build Bot

Comment 5 2017-05-17 03:22:37 PDT

Created attachment 310371 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-05-17 07:44:17 PDT

Comment on attachment 310359 [details] Patch Attachment 310359 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3762857 New failing tests: http/tests/media/hls/video-controls-live-stream.html

Build Bot

Comment 7 2017-05-17 07:44:18 PDT

Created attachment 310389 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Ryosuke Niwa

Comment 8 2017-05-17 13:52:40 PDT

Comment on attachment 310359 [details] Patch Clearing flags on attachment: 310359 Committed r216996: <http://trac.webkit.org/changeset/216996>

Ryosuke Niwa

Comment 9 2017-05-17 13:52:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.