Bug 172195

Summary:

Move-related refactoring on UserMediaPermissionRequestProxy

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, eric.carlson, jonlee, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch for landing	none

Description youenn fablet 2017-05-16 15:49:58 PDT

We should move some vectors to not reallocate them

Comment 1 youenn fablet 2017-05-16 15:52:19 PDT

Created attachment 310309 [details]
Patch

Comment 2 youenn fablet 2017-05-16 16:09:36 PDT

Created attachment 310314 [details]
Patch

Comment 3 youenn fablet 2017-05-16 16:38:53 PDT

Created attachment 310316 [details]
Patch

Comment 4 youenn fablet 2017-05-16 16:53:22 PDT

Created attachment 310320 [details]
Patch

Comment 5 Radar WebKit Bug Importer 2017-05-16 17:18:32 PDT

<rdar://problem/32236745>

Comment 6 Build Bot 2017-05-16 17:48:39 PDT

Comment on attachment 310320 [details]
Patch

Attachment 310320 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3753895

New failing tests:
http/tests/appcache/404-resource-with-slow-main-resource.php

Comment 7 Build Bot 2017-05-16 17:48:40 PDT

Created attachment 310331 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 8 Build Bot 2017-05-16 18:04:29 PDT

Comment on attachment 310320 [details]
Patch

Attachment 310320 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3754116

Number of test failures exceeded the failure limit.

Comment 9 Build Bot 2017-05-16 18:04:30 PDT

Created attachment 310337 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 10 Build Bot 2017-05-16 18:29:19 PDT

Comment on attachment 310320 [details]
Patch

Attachment 310320 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3754135

New failing tests:
webrtc/peer-connection-remote-audio-mute.html
webrtc/video-remote-mute.html
webrtc/audio-replace-track.html
webrtc/libwebrtc/descriptionGetters.html
webrtc/release-after-getting-track.html
webrtc/audio-peer-connection-webaudio.html
webrtc/peer-connection-audio-mute.html
webrtc/video-mediastreamtrack-stats.html
webrtc/video-addTrack.html
webrtc/video-disabled-black.html
webrtc/video-autoplay.html
webrtc/ephemeral-certificates-and-cnames.html
webrtc/multi-video.html
webrtc/connection-state.html
platform/ios/mediastream/getUserMedia-single-capture.html
webrtc/video-with-data-channel.html

Comment 11 Build Bot 2017-05-16 18:29:20 PDT

Created attachment 310339 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

Comment 12 youenn fablet 2017-05-17 11:18:08 PDT

Created attachment 310414 [details]
Patch for landing

Comment 13 WebKit Commit Bot 2017-05-17 13:07:31 PDT

Comment on attachment 310414 [details]
Patch for landing

Clearing flags on attachment: 310414

Committed r216991: <http://trac.webkit.org/changeset/216991>

Comment 14 WebKit Commit Bot 2017-05-17 13:07:32 PDT

All reviewed patches have been landed.  Closing bug.