Bug 172195

Summary:

Move-related refactoring on UserMediaPermissionRequestProxy

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, eric.carlson, jonlee, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch for landing	none

youenn fablet

Reported 2017-05-16 15:49:58 PDT

We should move some vectors to not reallocate them

Attachments
Patch (10.20 KB, patch) 2017-05-16 15:52 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (10.49 KB, patch) 2017-05-16 16:09 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (10.48 KB, patch) 2017-05-16 16:38 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (12.29 KB, patch) 2017-05-16 16:53 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.05 MB, application/zip) 2017-05-16 17:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.30 MB, application/zip) 2017-05-16 18:04 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.00 MB, application/zip) 2017-05-16 18:29 PDT, Build Bot	no flags	Details
Patch for landing (12.86 KB, patch) 2017-05-17 11:18 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-05-16 15:52:19 PDT

Created attachment 310309 [details] Patch

youenn fablet

Comment 2 2017-05-16 16:09:36 PDT

Created attachment 310314 [details] Patch

youenn fablet

Comment 3 2017-05-16 16:38:53 PDT

Created attachment 310316 [details] Patch

youenn fablet

Comment 4 2017-05-16 16:53:22 PDT

Created attachment 310320 [details] Patch

Radar WebKit Bug Importer

Comment 5 2017-05-16 17:18:32 PDT

<rdar://problem/32236745>

Build Bot

Comment 6 2017-05-16 17:48:39 PDT

Comment on attachment 310320 [details] Patch Attachment 310320 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3753895 New failing tests: http/tests/appcache/404-resource-with-slow-main-resource.php

Build Bot

Comment 7 2017-05-16 17:48:40 PDT

Created attachment 310331 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-05-16 18:04:29 PDT

Comment on attachment 310320 [details] Patch Attachment 310320 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3754116 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-05-16 18:04:30 PDT

Created attachment 310337 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2017-05-16 18:29:19 PDT

Comment on attachment 310320 [details] Patch Attachment 310320 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3754135 New failing tests: webrtc/peer-connection-remote-audio-mute.html webrtc/video-remote-mute.html webrtc/audio-replace-track.html webrtc/libwebrtc/descriptionGetters.html webrtc/release-after-getting-track.html webrtc/audio-peer-connection-webaudio.html webrtc/peer-connection-audio-mute.html webrtc/video-mediastreamtrack-stats.html webrtc/video-addTrack.html webrtc/video-disabled-black.html webrtc/video-autoplay.html webrtc/ephemeral-certificates-and-cnames.html webrtc/multi-video.html webrtc/connection-state.html platform/ios/mediastream/getUserMedia-single-capture.html webrtc/video-with-data-channel.html

Build Bot

Comment 11 2017-05-16 18:29:20 PDT

Created attachment 310339 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

youenn fablet

Comment 12 2017-05-17 11:18:08 PDT

Created attachment 310414 [details] Patch for landing

WebKit Commit Bot

Comment 13 2017-05-17 13:07:31 PDT

Comment on attachment 310414 [details] Patch for landing Clearing flags on attachment: 310414 Committed r216991: <http://trac.webkit.org/changeset/216991>

WebKit Commit Bot

Comment 14 2017-05-17 13:07:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.