Bug 172166

Summary:

Consider not exposing webkitURL in workers

Product:

WebKit

Reporter:

Anne van Kesteren <annevk>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cdumez, commit-queue, esprehn+autocc, ggaren, kondapallykalyan, rniwa, sam, zcorpan

Priority:

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none

Anne van Kesteren

Reported 2017-05-16 05:49:48 PDT

Per https://github.com/heycam/webidl/issues/362 Chrome does not do that either.

Attachments
WIP Patch (733 bytes, patch) 2017-05-19 16:41 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (986.31 KB, application/zip) 2017-05-19 17:51 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.06 MB, application/zip) 2017-05-19 17:51 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.84 MB, application/zip) 2017-05-19 17:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (931.63 KB, application/zip) 2017-05-19 18:12 PDT, Build Bot	no flags	Details
Patch (3.77 KB, patch) 2017-05-19 18:17 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Simon Pieters (:zcorpan)

Comment 1 2017-05-18 04:46:55 PDT

In Chromium this is effectively a [LegacyWindowAlias] for URL.

Chris Dumez

Comment 2 2017-05-19 16:41:40 PDT

Created attachment 310723 [details] WIP Patch

Build Bot

Comment 3 2017-05-19 17:51:38 PDT

Comment on attachment 310723 [details] WIP Patch Attachment 310723 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3779999 New failing tests: js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 4 2017-05-19 17:51:39 PDT

Created attachment 310736 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-05-19 17:51:52 PDT

Comment on attachment 310723 [details] WIP Patch Attachment 310723 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3779983 New failing tests: js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 6 2017-05-19 17:51:54 PDT

Created attachment 310737 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-05-19 17:53:02 PDT

Comment on attachment 310723 [details] WIP Patch Attachment 310723 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3779935 New failing tests: js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 8 2017-05-19 17:53:03 PDT

Created attachment 310738 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-05-19 18:12:54 PDT

Comment on attachment 310723 [details] WIP Patch Attachment 310723 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3780025 New failing tests: js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 10 2017-05-19 18:12:56 PDT

Created attachment 310741 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Chris Dumez

Comment 11 2017-05-19 18:17:42 PDT

Created attachment 310742 [details] Patch

Geoffrey Garen

Comment 12 2017-05-19 19:01:47 PDT

Comment on attachment 310742 [details] Patch r=me

WebKit Commit Bot

Comment 13 2017-05-19 19:30:31 PDT

Comment on attachment 310742 [details] Patch Clearing flags on attachment: 310742 Committed r217181: <http://trac.webkit.org/changeset/217181>

WebKit Commit Bot

Comment 14 2017-05-19 19:30:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.