Summary: | Modernize WebKit2 getUserMedia passing of parameters | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, jonlee, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2017-05-15 22:50:19 PDT
Created attachment 310266 [details]
Patch
(In reply to youenn fablet from comment #2) > Created attachment 310266 [details] > Patch Patch also fixes a crash I had in my local iOS build, when the completionHandler was being destroyed. Comment on attachment 310266 [details] Patch Attachment 310266 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3751524 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html Created attachment 310278 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Build Bot from comment #4) > Comment on attachment 310266 [details] > Patch > > Attachment 310266 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/3751524 > > New failing tests: > media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen- > media-controls-buttons-styles.html Failing test is unrelated and flaky (but rarely) on wk1 bot Comment on attachment 310266 [details] Patch Rejecting attachment 310266 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 310266, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit 0113371..3758007 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 216944 = 0113371f560dc83435b1082e25dc4332c95fdc35 r216945 = 3758007cfeb4678862ea3947526e88a9c6ea52a5 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3752578 Comment on attachment 310266 [details] Patch Rejecting attachment 310266 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 310266, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: xy.cpp patching file Source/WebKit2/UIProcess/UserMediaPermissionRequestProxy.h patching file Source/WebKit2/UIProcess/WebPageProxy.cpp patching file Source/WebKit2/UIProcess/WebPageProxy.h patching file Source/WebKit2/UIProcess/WebPageProxy.messages.in patching file Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3752770 Created attachment 310306 [details]
Rebasing patch
Comment on attachment 310306 [details] Rebasing patch Clearing flags on attachment: 310306 Committed r216952: <http://trac.webkit.org/changeset/216952> All reviewed patches have been landed. Closing bug. |