Bug 172156

Summary: Bring Notification.idl up to spec
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://notifications.spec.whatwg.org/#api
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2017-05-15 19:29:51 PDT
Bring Notification.idl up to spec
Attachments
Patch (60.00 KB, patch)
2017-05-16 10:47 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (59.94 KB, patch)
2017-05-16 15:02 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-05-16 10:47:41 PDT
Created attachment 310274 [details] Patch
Build Bot
Comment 2 2017-05-16 10:50:48 PDT
Attachment 310274 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebNotification.mm:138: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 1 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2017-05-16 15:02:31 PDT
Created attachment 310302 [details] Patch
Build Bot
Comment 4 2017-05-16 15:05:16 PDT
Attachment 310302 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebNotification.mm:138: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 1 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2017-05-16 15:56:00 PDT
BTW, it seems there are notifications tests in web-platform-tests we may want to import.
Sam Weinig
Comment 6 2017-05-16 16:06:54 PDT
Ok, filed https://bugs.webkit.org/show_bug.cgi?id=172196 to track that.
Chris Dumez
Comment 7 2017-05-16 19:54:43 PDT
Comment on attachment 310302 [details] Patch r=me
WebKit Commit Bot
Comment 8 2017-05-16 20:22:42 PDT
Comment on attachment 310302 [details] Patch Clearing flags on attachment: 310302 Committed r216967: <http://trac.webkit.org/changeset/216967>
WebKit Commit Bot
Comment 9 2017-05-16 20:22:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.