Summary: | Bring Notification.idl up to spec | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | https://notifications.spec.whatwg.org/#api | ||||||||
Attachments: |
|
Description
Sam Weinig
2017-05-15 19:29:51 PDT
Created attachment 310274 [details]
Patch
Attachment 310274 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebNotification.mm:138: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Total errors found: 1 in 34 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 310302 [details]
Patch
Attachment 310302 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebNotification.mm:138: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Total errors found: 1 in 34 files
If any of these errors are false positives, please file a bug against check-webkit-style.
BTW, it seems there are notifications tests in web-platform-tests we may want to import. Ok, filed https://bugs.webkit.org/show_bug.cgi?id=172196 to track that. Comment on attachment 310302 [details]
Patch
r=me
Comment on attachment 310302 [details] Patch Clearing flags on attachment: 310302 Committed r216967: <http://trac.webkit.org/changeset/216967> All reviewed patches have been landed. Closing bug. |