Bug 172141

Summary: browserbench.org/Speedometer/ should show the benchmark not an index of files
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+, ap: commit-queue-

Ryosuke Niwa
Reported 2017-05-15 16:40:22 PDT
browserbench.org/Speedometer/ should show the benchmark not an index of files
Attachments
Patch (11.33 KB, patch)
2017-05-15 16:41 PDT, Ryosuke Niwa 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-05-15 16:41:19 PDT
Created attachment 310182 [details] Patch
Alexey Proskuryakov
Comment 2 2017-05-15 18:43:45 PDT
Comment on attachment 310182 [details] Patch r=me, however what about these? Tools//Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:diff --git a/Full.html b/Full.html Tools//Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:--- a/Full.html Tools//Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:+++ b/Full.html Tools//Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: "entry_point": "Full.html",
Ryosuke Niwa
Comment 3 2017-05-15 18:57:57 PDT
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 310182 [details] > Patch > > r=me, however what about these? > > Tools//Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:diff > --git a/Full.html b/Full.html > Tools//Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:--- > a/Full.html > Tools//Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:+++ > b/Full.html > Tools//Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: > "entry_point": "Full.html", Those aren't affected because I'm only modifying the contents of browserbench.org, not the copy in PerformanceTests, which is getting upgraded to Speedometer 2.0 anyway so I'd update the plan file once we're done updating the benchmark.
Ryosuke Niwa
Comment 4 2017-05-15 18:59:12 PDT
Committed r216897: <http://trac.webkit.org/changeset/216897>
Note You need to log in before you can comment on or make changes to this bug.