Bug 172133

Summary: Make the application PID available to WebCore
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, ddkilzer, kling, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172152    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Andy Estes 2017-05-15 14:13:55 PDT
Make the application PID available to WebCore
Comment 1 Andy Estes 2017-05-15 14:22:57 PDT
Created attachment 310165 [details]
Patch
Comment 2 Andy Estes 2017-05-15 15:53:59 PDT
Created attachment 310176 [details]
Patch
Comment 3 Andreas Kling 2017-05-15 16:15:39 PDT
Comment on attachment 310176 [details]
Patch

r=me
I liked the old name better. applicationPID is rather ambiguous.
Comment 4 Andy Estes 2017-05-15 17:41:10 PDT
Created attachment 310197 [details]
Patch
Comment 5 Andy Estes 2017-05-15 17:50:11 PDT
Created attachment 310198 [details]
Patch
Comment 6 Andy Estes 2017-05-15 21:02:43 PDT
Created attachment 310216 [details]
Patch
Comment 7 WebKit Commit Bot 2017-05-15 23:07:02 PDT
Comment on attachment 310216 [details]
Patch

Clearing flags on attachment: 310216

Committed r216903: <http://trac.webkit.org/changeset/216903>
Comment 8 WebKit Commit Bot 2017-05-15 23:07:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Sam Weinig 2017-05-16 11:19:59 PDT
Is PID really what you want here? More and more, we have been moving away from using the PID and instead using the audit_token.
Comment 10 Andy Estes 2017-05-16 11:39:26 PDT
(In reply to Sam Weinig from comment #9)
> Is PID really what you want here? More and more, we have been moving away
> from using the PID and instead using the audit_token.

The patch in bug #172152 should hopefully answer your question about why we want a PID.

Maybe NEFilterSource should be asking us for audit tokens instead of PIDs, but they aren't at present.
Comment 11 Sam Weinig 2017-05-16 16:05:09 PDT
(In reply to Andy Estes from comment #10)
> (In reply to Sam Weinig from comment #9)
> > Is PID really what you want here? More and more, we have been moving away
> > from using the PID and instead using the audit_token.
> 
> The patch in bug #172152 should hopefully answer your question about why we
> want a PID.
> 
> Maybe NEFilterSource should be asking us for audit tokens instead of PIDs,
> but they aren't at present.

The almost certainly should :(.