Summary: | Make the application PID available to WebCore | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, ddkilzer, kling, sam, simon.fraser | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 172152 | ||||||||||||||
Attachments: |
|
Description
Andy Estes
2017-05-15 14:13:55 PDT
Created attachment 310165 [details]
Patch
Created attachment 310176 [details]
Patch
Comment on attachment 310176 [details]
Patch
r=me
I liked the old name better. applicationPID is rather ambiguous.
Created attachment 310197 [details]
Patch
Created attachment 310198 [details]
Patch
Created attachment 310216 [details]
Patch
Comment on attachment 310216 [details] Patch Clearing flags on attachment: 310216 Committed r216903: <http://trac.webkit.org/changeset/216903> All reviewed patches have been landed. Closing bug. Is PID really what you want here? More and more, we have been moving away from using the PID and instead using the audit_token. (In reply to Sam Weinig from comment #9) > Is PID really what you want here? More and more, we have been moving away > from using the PID and instead using the audit_token. The patch in bug #172152 should hopefully answer your question about why we want a PID. Maybe NEFilterSource should be asking us for audit tokens instead of PIDs, but they aren't at present. (In reply to Andy Estes from comment #10) > (In reply to Sam Weinig from comment #9) > > Is PID really what you want here? More and more, we have been moving away > > from using the PID and instead using the audit_token. > > The patch in bug #172152 should hopefully answer your question about why we > want a PID. > > Maybe NEFilterSource should be asking us for audit tokens instead of PIDs, > but they aren't at present. The almost certainly should :(. |