Bug 17211

Summary: MSVC7 fixes
Product: WebKit Reporter: Kevin Ollivier <kevino>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Wx
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
fixing MSVC7 build eric: review+

Description Kevin Ollivier 2008-02-07 15:01:51 PST 
Couple quick MSVC7 fixes. First, USER_TIMER_MINIMUM/MAXIMUM is not defined under MSVC 2003 SDK for some reason, and second, there seems to be a problem with the Interlocked* functions on MSVC7. Fixes are attached.
Comment 1 Kevin Ollivier 2008-02-07 15:02:41 PST 
Created attachment 18992 [details]
fixing MSVC7 build
Comment 2 Alexey Proskuryakov 2008-02-08 05:30:31 PST 
Comment on attachment 18992 [details]
fixing MSVC7 build

+        - On MSVC7, when the Interlocked* functions are used, the ref count gets out of sync.

Weird!
Comment 3 Adam Roben (:aroben) 2008-02-08 14:24:23 PST 
Comment on attachment 18992 [details]
fixing MSVC7 build

r=me
Comment 4 Eric Seidel (no email) 2008-02-08 14:24:23 PST 
Comment on attachment 18992 [details]
fixing MSVC7 build

This looks fine to me.  I think sfalken or aroben or one of the frequent windows hackers should give it the official r+.
Comment 5 Eric Seidel (no email) 2008-02-08 14:24:45 PST 
Comment on attachment 18992 [details]
fixing MSVC7 build

Stupid bugzilla.
Comment 6 Mark Rowe (bdash) 2008-02-09 04:01:42 PST 
This was landed in <http://trac.webkit.org/projects/webkit/changeset/30108>.  Kevin, can you make sure to close the bugs when you land the patches?