[css-grid] Fix static position of positioned grid items

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Manuel Rego Casasnovas]

Text on the spec (https://drafts.csswg.org/css-grid/#static-position):
  "The static position of an absolutely-positioned child
   of a grid container is determined as if it were the sole grid item
   in a grid area whose edges coincide with the padding edges
   of the grid container."

This has been already fixed in Blink:
https://codereview.chromium.org/2665983004

[Manuel Rego Casasnovas]

Created attachment 310118 [details]
Patch

[Javier Fernandez]

Comment on attachment 310118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310118&action=review

> Source/WebCore/rendering/RenderGrid.cpp:938
> +    childLayer->setStaticBlockPosition(LayoutUnit(borderBefore()));

boderStart() and boderBefore() already return a LayoutUnit, why do we need to create a new one ?

[Manuel Rego Casasnovas]

Created attachment 310126 [details]
Patch

New version applying suggested changes

[Manuel Rego Casasnovas]

Comment on attachment 310118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310118&action=review

>> Source/WebCore/rendering/RenderGrid.cpp:938
>> +    childLayer->setStaticBlockPosition(LayoutUnit(borderBefore()));
> 
> boderStart() and boderBefore() already return a LayoutUnit, why do we need to create a new one ?

Indeed we don't need that. Fixed in the new version of the patch. Thanks!

[WebKit Commit Bot]

Comment on attachment 310126 [details]
Patch

Clearing flags on attachment: 310126

Committed r216916: <http://trac.webkit.org/changeset/216916>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.