Bug 172088

Summary: Always reset the assisted node when the main frame commits a new load.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit2Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, kling, koivisto
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews113 for mac-elcapitan none

Description Andreas Kling 2017-05-13 22:03:18 PDT 
WebPage::m_assistedNode can extend the lifetime of a DOM node longer than necessary.
Comment 1 Andreas Kling 2017-05-13 22:04:02 PDT 
Created attachment 310064 [details]
Patch
Comment 2 Build Bot 2017-05-13 23:15:01 PDT 
Comment on attachment 310064 [details]
Patch

Attachment 310064 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3736807

New failing tests:
fast/dom/Window/setTimeout-setInterval-unique.html
Comment 3 Build Bot 2017-05-13 23:15:02 PDT 
Created attachment 310069 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Andreas Kling 2017-05-14 11:11:55 PDT 
The failure is unrelated. It's a debug crash on WK1 and patch only affects WK2.
Comment 5 WebKit Commit Bot 2017-05-14 12:27:48 PDT 
Comment on attachment 310064 [details]
Patch

Clearing flags on attachment: 310064

Committed r216847: <http://trac.webkit.org/changeset/216847>
Comment 6 WebKit Commit Bot 2017-05-14 12:27:50 PDT 
All reviewed patches have been landed.  Closing bug.