Bug 172066

Summary:

Drop uses of PassRefPtr in WebKit/mac

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, darin, kling, koivisto, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-05-12 19:22:56 PDT

Drop uses of PassRefPtr in WebKit/mac.

Attachments
Patch (55.11 KB, patch) 2017-05-12 19:31 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (55.11 KB, patch) 2017-05-12 19:55 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (55.13 KB, patch) 2017-05-12 20:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (57.65 KB, patch) 2017-05-12 20:22 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-05-12 19:31:30 PDT

Created attachment 309997 [details] Patch

Build Bot

Comment 2 2017-05-12 19:32:31 PDT

Attachment 309997 [details] did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.h:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:90: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:1259: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.h:113: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm:87: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.h:59: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 6 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2017-05-12 19:55:00 PDT

Created attachment 310000 [details] Patch

Build Bot

Comment 4 2017-05-12 19:56:45 PDT

Attachment 310000 [details] did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.h:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:90: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:1259: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.h:113: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm:87: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.h:59: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 6 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 5 2017-05-12 20:02:20 PDT

Created attachment 310002 [details] Patch

Build Bot

Comment 6 2017-05-12 20:03:35 PDT

Attachment 310002 [details] did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.h:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:90: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:1259: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.h:113: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm:87: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.h:59: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 6 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 7 2017-05-12 20:22:24 PDT

Created attachment 310005 [details] Patch

Build Bot

Comment 8 2017-05-12 20:24:52 PDT

Attachment 310005 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebArchive.mm:89: Missing spaces around | [whitespace/operators] [3] ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.h:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:90: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:1259: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebNetscapePluginView.h:113: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm:87: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.h:59: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 7 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 9 2017-05-12 22:26:16 PDT

Comment on attachment 310005 [details] Patch Clearing flags on attachment: 310005 Committed r216816: <http://trac.webkit.org/changeset/216816>

Chris Dumez

Comment 10 2017-05-12 22:26:18 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.