Bug 172029 – Stop using PassRefPtr under WebKit2/UIProcess

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Stop using PassRefPtr under WebKit2/UIProcess.

[Chris Dumez]

Created attachment 309901 [details]
Patch

[Build Bot]

Attachment 309901 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:5715:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 309902 [details]
Patch

[Build Bot]

Attachment 309902 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:5715:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 309903 [details]
Patch

[Build Bot]

Attachment 309903 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:5715:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Comment on attachment 309903 [details]
Patch

Clearing flags on attachment: 309903

Committed r216794: <http://trac.webkit.org/changeset/216794>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 309903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309903&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:862
> +    void registerEditCommand(Ref<WebEditCommandProxy>&&, UndoOrRedo);

I think this should take WebEditCommandProxy&; it’s not transferring ownership. As far as I can tell, the callers are passing *this, not a newly created object nor the last reference to an object.

[Chris Dumez]

(In reply to Darin Adler from comment #9)
> Comment on attachment 309903 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309903&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:862
> > +    void registerEditCommand(Ref<WebEditCommandProxy>&&, UndoOrRedo);
> 
> I think this should take WebEditCommandProxy&; it’s not transferring
> ownership. As far as I can tell, the callers are passing *this, not a newly
> created object nor the last reference to an object.

2 call sites pass *this and another passes a Ref<>&&:
void WebPageProxy::registerEditCommandForUndo(uint64_t commandID, uint32_t editAction)
{
    registerEditCommand(WebEditCommandProxy::create(commandID, static_cast<EditAction>(editAction), this), Undo);
}

Also, the implementation ends up storing the command into a RefPtr.