Bug 172021

Summary:

Cleanup: Make QueueTaskToEventLoopFunctionPtr take JSGlobalObject&

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, darin, keith_miller, mark.lam, msaboff, saam, sam

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2017-05-11 22:31:58 PDT

Currently JSGlobalObject::queueTaskToEventLoop() takes a const JSGlobalObject* whose constness is removed in the implementation of this method in all derived classes. We should have JSGlobalObject::queueTaskToEventLoop() take a non-const JSGlobalObject* and remove the need to effectively const_cast<> it. This will also make the data types of the arguments to JSGlobalObject::queueTaskToEventLoop() match the data types for the same arguments passed to the analogous VM::queueMicrotask().

Attachments
Patch (13.45 KB, patch) 2017-05-11 23:49 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2017-05-11 23:46:08 PDT

s/QueueTaskToEventLoopFunctionPtr/JSGlobalObject::queueTaskToEventLoop()

Daniel Bates

Comment 2 2017-05-11 23:47:00 PDT

Actually, we should make QueueTaskToEventLoopFunctionPtr take JSGlobalObject& as all existing callers expect a non-const, non-null JSGlobalObject object.

Daniel Bates

Comment 3 2017-05-11 23:49:05 PDT

Created attachment 309876 [details] Patch

Mark Lam

Comment 4 2017-05-12 10:38:49 PDT

Comment on attachment 309876 [details] Patch r=me

Daniel Bates

Comment 5 2017-05-12 10:53:22 PDT

Comment on attachment 309876 [details] Patch Clearing flags on attachment: 309876 Committed r216768: <http://trac.webkit.org/changeset/216768>

Daniel Bates

Comment 6 2017-05-12 10:53:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.