Bug 17201

Summary: Use RefPtr in CSSParser::parseFont() to get rid of goto silliness
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: CSSAssignee: Nobody <webkit-unassigned>
Severity: Minor Keywords: EasyFix
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Description Flags
First attempt ddkilzer: review+

Description David Kilzer (:ddkilzer) 2008-02-06 14:28:33 PST
CSSParser::parseFont() uses goto statements to release the FontValue object on early exit.  It should be using a RefPtr<FontValue> instead.
Comment 1 Rob Buis 2008-02-10 23:31:24 PST
Created attachment 19059 [details]
First attempt

Gets rid of the goto usage in parseFont.

Comment 2 David Kilzer (:ddkilzer) 2008-02-11 06:23:22 PST
Comment on attachment 19059 [details]
First attempt

Thanks Rob!!  r=me

Please remove tabs from the ChangeLog before landing!
Comment 3 Rob Buis 2008-02-11 13:06:48 PST
Landed in 30152.