Bug 171990

Summary:

WorkerThread::stop() should not access m_workerGlobalScope->script() after posting the cleanup task.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

buildbot, ggaren, rniwa, ryanhaddad

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

171775

Attachments:

Description	Flags
proposed patch.	mark.lam: review-, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none

Mark Lam

Reported 2017-05-11 14:32:39 PDT

The cleanup task will invoke workerGlobalScope.clearScript() which deletes the WorkerScriptController. Hence, it is not safe for WorkerThread::stop() to access the script controller after it has posted the cleanup task.

Attachments
proposed patch. (5.37 KB, patch) 2017-05-11 14:59 PDT, Mark Lam	mark.lam: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.09 MB, application/zip) 2017-05-11 16:06 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.10 MB, application/zip) 2017-05-11 16:13 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2017-05-11 14:41:55 PDT

FYI, this issue was found by a test: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r216684%20(1509)/results.html

Mark Lam

Comment 2 2017-05-11 14:59:26 PDT

Created attachment 309792 [details] proposed patch. Let's get some EWS testing first.

Alexey Proskuryakov

Comment 3 2017-05-11 15:59:42 PDT

Looks like there are many crashes and failures on worker tests.

Build Bot

Comment 4 2017-05-11 16:06:23 PDT

Comment on attachment 309792 [details] proposed patch. Attachment 309792 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3721396 New failing tests: crypto/workers/subtle/hrsa-postMessage-worker.html workers/bomb.html imported/w3c/web-platform-tests/resource-timing/rt-serialization.html performance-api/performance-observer-basic.html

Build Bot

Comment 5 2017-05-11 16:06:24 PDT

Created attachment 309806 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-05-11 16:13:45 PDT

Comment on attachment 309792 [details] proposed patch. Attachment 309792 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3721411 New failing tests: crypto/workers/subtle/rsa-postMessage-worker.html fetch/header-constructor-is-array.html

Build Bot

Comment 7 2017-05-11 16:13:46 PDT

Created attachment 309809 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Mark Lam

Comment 8 2017-05-11 16:13:53 PDT

Comment on attachment 309792 [details] proposed patch. I'm investigating the failures.

Mark Lam

Comment 9 2017-05-12 08:47:19 PDT

r216677 has been rolled out. This bug is no longer needed. Will rework the original fix in https://bugs.webkit.org/show_bug.cgi?id=171775. *** This bug has been marked as a duplicate of bug 171775 ***

Note You need to log in before you can comment on or make changes to this bug.