Summary: | REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Tools / Tests | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, jer.noble, joepeck, lforschler, mark.lam, simon.fraser, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-05-11 14:27:15 PDT
Created attachment 309786 [details]
[PATCH] Proposed Fix
Created attachment 309787 [details]
[PATCH] Proposed Fix
Comment on attachment 309787 [details]
[PATCH] Proposed Fix
r=me
r=me too. Very nice. The commit-queue encountered the following flaky tests while processing attachment 309787 [details]: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 309787 [details] [PATCH] Proposed Fix Rejecting attachment 309787 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309787, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ingContext should implement WebGLRenderingContextBase The copy of the patch that failed is found in: /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch When you have resolved this problem, run "git rebase --continue". If you prefer to skip this patch, run "git rebase --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2719. Full output: http://webkit-queues.webkit.org/results/3721293 (In reply to WebKit Commit Bot from comment #7) > Comment on attachment 309787 [details] > [PATCH] Proposed Fix > > Rejecting attachment 309787 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', > 'land-attachment', '--force-clean', '--non-interactive', > '--parent-command=commit-queue', 309787, '--port=mac']" exit_code: 2 cwd: > /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > ingContext should implement WebGLRenderingContextBase > The copy of the patch that failed is found in: > /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch > > When you have resolved this problem, run "git rebase --continue". > If you prefer to skip this patch, run "git rebase --skip" instead. > To check out the original branch and stop rebasing, run "git rebase --abort". > > rebase refs/remotes/origin/master: command returned error: 1 > > Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2719. > > Full output: http://webkit-queues.webkit.org/results/3721293 You had one job, commit-queue bot.. you are fired. Comment on attachment 309787 [details]
[PATCH] Proposed Fix
Lets try setting the flag again. I really don't want to do an entire clean build to land this.
Comment on attachment 309787 [details] [PATCH] Proposed Fix Clearing flags on attachment: 309787 Committed r216701: <http://trac.webkit.org/changeset/216701> All reviewed patches have been landed. Closing bug. |