Bug 171988

Summary: Cleanup: Use Ref instead of RefPtr to hold DOMWrapperWorld
Product: WebKit Reporter: Daniel Bates <dbates>
Component: BindingsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, dbates, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews101 for mac-elcapitan none

Daniel Bates
Reported 2017-05-11 14:20:38 PDT
We should use Ref<> instead of RefPtr<> to hold DOMWrapperWorld as it cannot be null.
Attachments
Patch (9.25 KB, patch)
2017-05-11 14:21 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (9.25 KB, patch)
2017-05-11 14:24 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-elcapitan (1023.67 KB, application/zip)
2017-05-11 15:40 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-05-11 14:21:57 PDT
Created attachment 309783 [details] Patch
Daniel Bates
Comment 2 2017-05-11 14:24:15 PDT
Created attachment 309784 [details] Patch
Build Bot
Comment 3 2017-05-11 15:40:15 PDT
Comment on attachment 309784 [details] Patch Attachment 309784 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3721159 New failing tests: workers/bomb.html
Build Bot
Comment 4 2017-05-11 15:40:16 PDT
Created attachment 309800 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Chris Dumez
Comment 5 2017-05-11 15:42:51 PDT
Comment on attachment 309784 [details] Patch r=me
Daniel Bates
Comment 6 2017-05-12 10:54:15 PDT
Comment on attachment 309784 [details] Patch Clearing flags on attachment: 309784 Committed r216769: <http://trac.webkit.org/changeset/216769>
Daniel Bates
Comment 7 2017-05-12 10:54:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.