Bug 171971

Summary: Web Inspector: Cannot delete a disabled XHR breakpoint
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2017-05-11 02:54:33 PDT
Summary: Wrong event dispatched when XHR breakpoint removed. The XHRBReakpointRemoved event is dispatched correctly, but only after dispatching a DOMBreakpointRemoved event. The spurious event isn't causing any errors, and should just be removed.
Attachments
Patch (10.20 KB, patch)
2017-05-17 14:07 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-05-11 03:01:02 PDT
While investigating I discovered a real bug in DOMDebuggerManager.removeXHRBreakpoint: Summary: Cannot delete a disabled XHR breakpoint. Steps to Reproduce: 1. Inspect any page > Debugger tab 2. Add an XHR breakpoint 3. Disable it 4. Remove the breakpoint (by pressing delete or right-clicking and using the context menu) => Breakpoint is not deleted 5. Enable the breakpoint then remove it again => Breakpoint is deleted Will retitle this bug and fix here.
Radar WebKit Bug Importer
Comment 2 2017-05-11 03:02:23 PDT
<rdar://problem/32129527>
Matt Baker
Comment 3 2017-05-17 14:07:50 PDT
Created attachment 310443 [details] Patch
Devin Rousso
Comment 4 2017-05-23 15:22:28 PDT
Comment on attachment 310443 [details] Patch r=me
WebKit Commit Bot
Comment 5 2017-05-23 15:58:26 PDT
Comment on attachment 310443 [details] Patch Clearing flags on attachment: 310443 Committed r217306: <http://trac.webkit.org/changeset/217306>
WebKit Commit Bot
Comment 6 2017-05-23 15:58:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.