Bug 171966

Summary: Stop using PassRefPtr in platform/audio
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-05-10 21:29:42 PDT
Stop using PassRefPtr in platform/audio.
Attachments
Patch (19.75 KB, patch)
2017-05-10 21:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.73 KB, patch)
2017-05-11 08:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-10 21:32:34 PDT
Created attachment 309690 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-10 22:14:48 PDT
Comment on attachment 309690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309690&action=review > Source/WebCore/platform/audio/HRTFDatabaseLoader.cpp:57 > + Ref<HRTFDatabaseLoader> loader = adoptRef(*new HRTFDatabaseLoader(sampleRate)); We can't use auto here? > Source/WebCore/platform/audio/mac/AudioBusMac.mm:-57 > - RefPtr<AudioBus> bus(createBusFromInMemoryAudioFile([audioData bytes], [audioData length], false, sampleRate)); > - return bus; This was a strange piece of code!
Chris Dumez
Comment 3 2017-05-11 08:47:39 PDT
Created attachment 309712 [details] Patch
WebKit Commit Bot
Comment 4 2017-05-11 09:30:04 PDT
Comment on attachment 309712 [details] Patch Clearing flags on attachment: 309712 Committed r216679: <http://trac.webkit.org/changeset/216679>
WebKit Commit Bot
Comment 5 2017-05-11 09:30:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.