| Summary: | [WTF] Export additional symbols in threading | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | Web Template Framework | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, mcatanzaro | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2017-05-10 16:14:15 PDT
Created attachment 309654 [details]
Patch
Adds WTF_EXPORT_PRIVATE to the functions
What does this fix? If those needed to be exported, then the build wouldn't work at all, right? (In reply to Michael Catanzaro from comment #2) > What does this fix? If those needed to be exported, then the build wouldn't > work at all, right? These symbols look to be used by WASM related code. Since there is no FTL support on Windows there is no WASM support. When it is there these will be required. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/wasm/WasmMachineThreads.cpp#L60 https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp#L127 Currently we're hitting this in the PlayStation port which also uses declspec. Actually it looks like when https://bugs.webkit.org/show_bug.cgi?id=171865 was reverted the WTF_EXPORT_PRIVATE symbol isn't exported so landing will cause a build breakage. Nvm its good for review Comment on attachment 309654 [details] Patch Clearing flags on attachment: 309654 Committed r217291: <http://trac.webkit.org/changeset/217291> All reviewed patches have been landed. Closing bug. |