Bug 171952

Summary: [WTF] Export additional symbols in threading
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Web Template FrameworkAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2017-05-10 16:14:15 PDT
sendMessageScoped and installSignalHandler are not exported as symbols for JSC.
Attachments
Patch (1.94 KB, patch)
2017-05-10 16:21 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-10 16:21:41 PDT
Created attachment 309654 [details] Patch Adds WTF_EXPORT_PRIVATE to the functions
Michael Catanzaro
Comment 2 2017-05-15 17:31:44 PDT
What does this fix? If those needed to be exported, then the build wouldn't work at all, right?
Don Olmstead
Comment 3 2017-05-22 18:14:06 PDT
(In reply to Michael Catanzaro from comment #2) > What does this fix? If those needed to be exported, then the build wouldn't > work at all, right? These symbols look to be used by WASM related code. Since there is no FTL support on Windows there is no WASM support. When it is there these will be required. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/wasm/WasmMachineThreads.cpp#L60 https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp#L127 Currently we're hitting this in the PlayStation port which also uses declspec.
Don Olmstead
Comment 4 2017-05-22 18:30:52 PDT
Actually it looks like when https://bugs.webkit.org/show_bug.cgi?id=171865 was reverted the WTF_EXPORT_PRIVATE symbol isn't exported so landing will cause a build breakage.
Don Olmstead
Comment 5 2017-05-22 19:10:52 PDT
Nvm its good for review
WebKit Commit Bot
Comment 6 2017-05-23 12:51:48 PDT
Comment on attachment 309654 [details] Patch Clearing flags on attachment: 309654 Committed r217291: <http://trac.webkit.org/changeset/217291>
WebKit Commit Bot
Comment 7 2017-05-23 12:51:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.