Bug 171950

Summary: [CMake] Add HAVE check for regex.h
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mcatanzaro: review+
Patch none

Don Olmstead
Reported 2017-05-10 15:46:01 PDT
Currently OS(POSIX) assumes that <regex.h> is present. CMake should be used to verify that this is correct.
Attachments
Patch (4.68 KB, patch)
2017-05-10 15:51 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (5.95 KB, patch)
2017-05-11 11:55 PDT, Don Olmstead 		mcatanzaro: review+
DetailsFormatted DiffDiff
Patch (5.93 KB, patch)
2017-05-11 13:30 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-10 15:51:36 PDT
Created attachment 309651 [details] Patch Adds HAVE_REGEX_H which is detected by CMake during configuration. Checks are added in ConfigFile and within the gtest framework. #define HAVE_REGEX_H is defined for OS(DARWIN) directly in Platform.h to not affect XCode builds.
Konstantin Tokarev
Comment 2 2017-05-11 10:21:04 PDT
Please fix Source/WebCore/WebCorePrefix.h and Source/WebCore/testing/js/WebCoreTestSupportPrefix.h as well
Don Olmstead
Comment 3 2017-05-11 11:55:19 PDT
Created attachment 309741 [details] Patch Adding additional guards as requested
Konstantin Tokarev
Comment 4 2017-05-11 12:04:45 PDT
Looks good to me
Michael Catanzaro
Comment 5 2017-05-11 13:27:02 PDT
Comment on attachment 309741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309741&action=review > Source/JavaScriptCore/runtime/ConfigFile.cpp:43 > +#if OS(UNIX) || OS(DARWIN) As discussed in #webkit, isn't the || OS(DARWIN) redundant here?
Don Olmstead
Comment 6 2017-05-11 13:30:08 PDT
Created attachment 309764 [details] Patch Removing || OS(DARWIN)
WebKit Commit Bot
Comment 7 2017-05-11 17:04:11 PDT
Comment on attachment 309764 [details] Patch Clearing flags on attachment: 309764 Committed r216705: <http://trac.webkit.org/changeset/216705>
WebKit Commit Bot
Comment 8 2017-05-11 17:04:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.