Bug 171907 – Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub

• Component: Web Inspector
• Status: RESOLVED FIXED

[Ross Kirsling]

Verification steps:
1. Ensure that InspectorFrontendHostStub is being used, or at the least, that InspectorFrontendHost.copyText is overridden to the stub implementation.
2. Do something that copies to the clipboard (e.g. Copy as cURL).
-- Clipboard is not updated (console error: "Clipboard access is denied").

Details:
- The copyText stub is calling document.execCommand("copy"), but there's no current selection, so this is guaranteed to fail.
- More specifically, instead of setting up the text to copy as a selection, we're just setting an unused field _textToCopy, which is a remnant of the old Inspector:
  https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js?rev=154828

[Ross Kirsling]

Created attachment 309574 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 309574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309574&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js:124
> +            const textarea = document.createElement("textarea");

Nit: We would typically use `let` instead of const, but it doesn't really matter.

Our style for when we use `const` tends to be when the value is the equivalent of a compile time constant. So `const timeToWait = 1000;" but not `const timeToWait = x * y;`. Maybe we should change that style though.

[Ross Kirsling]

Created attachment 309619 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 309619 [details]
Patch

Clearing flags on attachment: 309619

Committed r216602: <http://trac.webkit.org/changeset/216602>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.