Bug 171879

Summary: Introduce DocumentAndElementEventHandlers IDL interface
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, rniwa, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/#documentandelementeventhandlers
Attachments:
Description Flags
WIP Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-05-09 13:18:15 PDT
Introduce DocumentAndElementEventHandlers IDL interface: - https://html.spec.whatwg.org/#documentandelementeventhandlers This avoids duplication between Document.idl and Element.idl.
Attachments
WIP Patch (14.88 KB, patch)
2017-05-09 13:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.36 KB, patch)
2017-05-09 14:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.92 KB, patch)
2017-05-09 14:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-09 13:19:37 PDT
Created attachment 309530 [details] WIP Patch
Chris Dumez
Comment 2 2017-05-09 14:03:17 PDT
Created attachment 309536 [details] Patch
Ryosuke Niwa
Comment 3 2017-05-09 14:15:12 PDT
Comment on attachment 309536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309536&action=review > Source/WebCore/dom/Element.idl:131 > + // Non standard event handler. Maybe just "Non standard." would be sufficient? > LayoutTests/fast/events/DocumentAndElementEventHandlers-expected.txt:3 > +PASS Document handlers > +PASS Element handlers Can we split out the list of event handlers here? This output is really terse.
Ryosuke Niwa
Comment 4 2017-05-09 14:15:26 PDT
r=me as well.
Chris Dumez
Comment 5 2017-05-09 14:39:17 PDT
Created attachment 309543 [details] Patch
Chris Dumez
Comment 6 2017-05-09 14:40:16 PDT
Comment on attachment 309543 [details] Patch Clearing flags on attachment: 309543 Committed r216542: <http://trac.webkit.org/changeset/216542>
Chris Dumez
Comment 7 2017-05-09 14:40:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.