Bug 171836

Summary:

ontransitionend eventHandler should be in GlobalEventHandlers

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

CSS

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cmarcelo, commit-queue, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam, simon.fraser

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-05-08 16:21:40 PDT

ontransitionend eventHandler should be in GlobalEventHandlers: - https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl WebKit currently has in on Window and Element only. Firefox matches the specification.

Attachments
Patch (10.77 KB, patch) 2017-05-08 16:23 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.23 MB, application/zip) 2017-05-08 17:24 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.34 MB, application/zip) 2017-05-08 17:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.73 MB, application/zip) 2017-05-08 17:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (7.37 MB, application/zip) 2017-05-08 18:10 PDT, Build Bot	no flags	Details
Patch (14.12 KB, patch) 2017-05-08 20:43 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (961.17 KB, application/zip) 2017-05-08 21:52 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (899.38 KB, application/zip) 2017-05-08 21:57 PDT, Build Bot	no flags	Details
Patch (12.79 KB, patch) 2017-05-08 22:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (13.15 KB, patch) 2017-05-09 09:08 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-05-08 16:23:52 PDT

Created attachment 309436 [details] Patch

Build Bot

Comment 2 2017-05-08 17:24:15 PDT

Comment on attachment 309436 [details] Patch Attachment 309436 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3702041 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 3 2017-05-08 17:24:17 PDT

Created attachment 309444 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-05-08 17:45:46 PDT

Comment on attachment 309436 [details] Patch Attachment 309436 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3702107 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 5 2017-05-08 17:45:47 PDT

Created attachment 309448 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-05-08 17:55:03 PDT

Comment on attachment 309436 [details] Patch Attachment 309436 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3702122 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 7 2017-05-08 17:55:05 PDT

Created attachment 309449 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-05-08 18:10:06 PDT

Comment on attachment 309436 [details] Patch Attachment 309436 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3702155 New failing tests: fast/dom/event-handler-attributes.html

Build Bot

Comment 9 2017-05-08 18:10:07 PDT

Created attachment 309452 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Chris Dumez

Comment 10 2017-05-08 20:43:52 PDT

Created attachment 309463 [details] Patch

Build Bot

Comment 11 2017-05-08 21:52:25 PDT

Comment on attachment 309463 [details] Patch Attachment 309463 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3703172 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 12 2017-05-08 21:52:26 PDT

Created attachment 309467 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 13 2017-05-08 21:57:16 PDT

Comment on attachment 309463 [details] Patch Attachment 309463 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3703176 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 14 2017-05-08 21:57:18 PDT

Created attachment 309468 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Chris Dumez

Comment 15 2017-05-08 22:02:41 PDT

Created attachment 309469 [details] Patch

WebKit Commit Bot

Comment 16 2017-05-09 07:36:14 PDT

Comment on attachment 309469 [details] Patch Rejecting attachment 309469 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 309469, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: atching file LayoutTests/fast/css/ontransitionend-eventhandler.html patching file LayoutTests/fast/dom/event-handler-attributes-expected.txt patching file LayoutTests/fast/dom/event-handler-attributes.html patching file LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt patching file LayoutTests/platform/ios/fast/dom/event-handler-attributes-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3705732

Chris Dumez

Comment 17 2017-05-09 09:08:57 PDT

Created attachment 309502 [details] Patch

WebKit Commit Bot

Comment 18 2017-05-09 09:51:03 PDT

Comment on attachment 309502 [details] Patch Clearing flags on attachment: 309502 Committed r216510: <http://trac.webkit.org/changeset/216510>

WebKit Commit Bot

Comment 19 2017-05-09 09:51:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.