Bug 171835

Summary: build ImageDiff with host SDK from Make
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2017-05-08 15:59:33 PDT
Currently, Make will not build ImageDiff with the host SDK for iOS Simulator and iOS Device builds. Rather, it will build ImageDiff with the target SDK.
Attachments
Patch (1.09 KB, patch)
2017-05-08 16:04 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2017-05-09 10:00 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2017-05-09 10:21 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2017-05-08 16:04:43 PDT
Created attachment 309430 [details] Patch
Jonathan Bedard
Comment 2 2017-05-08 16:06:37 PDT
Split off from <https://bugs.webkit.org/show_bug.cgi?id=171788>.
Jonathan Bedard
Comment 3 2017-05-08 16:16:33 PDT
To continue some of the discussion from bug 171788, I can't think of a circumstance where a user would not want to build ImageDiff when building other tools. I also cannot think of a circumstance where a user would want to build ImageDiff with SDKROOT as iphone or as iphonesimulator.
Radar WebKit Bug Importer
Comment 4 2017-05-08 16:18:52 PDT
<rdar://problem/32062953>
Jonathan Bedard
Comment 5 2017-05-09 10:00:24 PDT
Created attachment 309509 [details] Patch
Jonathan Bedard
Comment 6 2017-05-09 10:21:15 PDT
Created attachment 309511 [details] Patch
Jonathan Bedard
Comment 7 2017-05-09 10:23:31 PDT
(In reply to Jonathan Bedard from comment #6) > Created attachment 309511 [details] > Patch This should be correct. It's taken from the code removed in <http://trac.webkit.org/changeset/212148>
WebKit Commit Bot
Comment 8 2017-05-09 11:07:23 PDT
Comment on attachment 309511 [details] Patch Clearing flags on attachment: 309511 Committed r216528: <http://trac.webkit.org/changeset/216528>
WebKit Commit Bot
Comment 9 2017-05-09 11:07:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.