Bug 171822 – [Sierra Release wk2] Multiple LayoutTest/inspector/debugger test flaky

• Component: Web Inspector
• Status: RESOLVED CONFIGURATION CHANGED

[Matt Lewis]

The tests:

inspector/debugger/async-stack-trace.html is flaky failure

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fasync-stack-trace.html
Diff:
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/async-stack-trace-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/async-stack-trace-actual.txt
@@ -1,5 +1,7 @@
 Tests for async stack traces.
 
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
 
 == Running test suite: AsyncStackTrace
 -- Running test case: CheckAsyncStackTrace.RequestAnimationFrame

The test
inspector/debugger/break-on-exception-throw-in-promise.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreak-on-exception-throw-in-promise.html
Diff
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/break-on-exception-throw-in-promise-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/break-on-exception-throw-in-promise-actual.txt
@@ -25,6 +25,8 @@
 CONSOLE MESSAGE: line 86: Unhandled Promise Rejection: TestError
 Checking pause locations within Promises when pausing on all exceptions.
 
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
 
 == Running test suite: BreakOnAnyException.Promise
 -- Running test case: BreakOnAnyException.Promise.ExceptionInPromiseConstructor

the test
inspector/debugger/break-on-uncaught-exception-throw-in-promise.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreak-on-uncaught-exception-throw-in-promise.html
diff:
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/break-on-uncaught-exception-throw-in-promise-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/break-on-uncaught-exception-throw-in-promise-actual.txt
@@ -25,6 +25,8 @@
 CONSOLE MESSAGE: line 86: Unhandled Promise Rejection: TestError
 Checking no pauses within Promises when pausing on uncaught exceptions.
 
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
 
 == Running test suite: BreakOnUncaughtException.Promise
 -- Running test case: BreakOnUncaughtException.Promise.ExceptionInPromiseConstructor

The test
inspector/debugger/break-on-uncaught-exception.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreak-on-uncaught-exception.html
diff
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/break-on-uncaught-exception-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/break-on-uncaught-exception-actual.txt
@@ -13,6 +13,8 @@
 CONSOLE MESSAGE: line 18: DONE
 Checking pause locations when pausing on uncaught exceptions.
 
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
 
 == Running test suite: BreakOnUncaughtException
 -- Running test case: BreakOnUncaughtException.UncaughtExceptionBasic



All four test seem to fail at the same time and in a very similar way.

Unsure that this is the reference point but this seem to start with these three revisions r216272, r216271, r216270
https://trac.webkit.org/log/webkit/?verbose=on&rev=216272&stop_rev=216270

[Ryan Haddad]

Seen with inspector/canvas tests here:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r220271%20(3377)/results.html

[Ryan Haddad]

*** Bug 174208 has been marked as a duplicate of this bug. ***

[Ryan Haddad]

*** Bug 173723 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

I have discovered what can cause this. I've made sure tests register a ScriptProfilerObserver and I've made the error message clear about which domain is missing having a dispatcher registered:

    ERROR: No domain dispatcher registered for domain 'ScriptProfiler'

So this shouldn't happen anymore, and if it does we have a clear path to a solution. Closing this.

See: Bug 176824

[Radar WebKit Bug Importer]

<rdar://problem/34694509>