Bug 171791

Summary: Clean up some WebProcessProxy, WebPage, and message handler includes
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bdakin, ggaren, ossy, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Tim Horton
Reported 2017-05-07 03:53:19 PDT
Clean up some WebProcessProxy, WebPage, and message handler includes
Attachments
Patch (39.95 KB, patch)
2017-05-07 03:54 PDT, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-05-07 03:54:25 PDT
Created attachment 309319 [details] Patch
Tim Horton
Comment 2 2017-05-07 03:55:28 PDT
This will probably take a few EWS iterations.
Tim Horton
Comment 3 2017-05-07 11:05:26 PDT
https://trac.webkit.org/changeset/216348/webkit
Csaba Osztrogonác
Comment 4 2017-05-07 23:43:42 PDT
(In reply to Tim Horton from comment #3) > https://trac.webkit.org/changeset/216348/webkit FYI, it broke the Apple Mac cmake build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1413
Csaba Osztrogonác
Comment 5 2017-05-07 23:45:46 PDT
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:34:10: fatal error: 'WebCore/CompositionUnderline.h' file not found #include <WebCore/CompositionUnderline.h> ^
Note You need to log in before you can comment on or make changes to this bug.