Bug 171765

Summary: Web Inspector: Make it easy to dynamically show/hide a SettingsView
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Video] SettingsView visibility demo
none
Patch
none
Patch none

Matt Baker
Reported 2017-05-05 19:09:00 PDT
Summary: Make it easy to dynamically show/hide a SettingsView. Notes: Hiding the selected view should cause a new view to become selected. Select the previous visible view, if one exists. Otherwise try the next visible view. Showing a view when no views are selected should cause the view to become selected.
Attachments
[Video] SettingsView visibility demo (192.01 KB, video/mp4)
2017-05-05 19:10 PDT, Matt Baker 		no flags
Details
Patch (14.91 KB, patch)
2017-05-05 19:15 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (15.62 KB, patch)
2017-05-08 13:06 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-05-05 19:09:29 PDT
<rdar://problem/32031280>
Matt Baker
Comment 2 2017-05-05 19:10:41 PDT
Created attachment 309257 [details] [Video] SettingsView visibility demo
Matt Baker
Comment 3 2017-05-05 19:15:11 PDT
Created attachment 309260 [details] Patch
Blaze Burg
Comment 4 2017-05-08 10:04:14 PDT
Comment on attachment 309260 [details] Patch r=me You should note in the ChangeLog how you tested this, since we only have one settings view in trunk.
Matt Baker
Comment 5 2017-05-08 13:06:40 PDT
Created attachment 309398 [details] Patch
Matt Baker
Comment 6 2017-05-08 13:07:45 PDT
Comment on attachment 309398 [details] Patch Updated Changelog with summary clarifying new behavior.
WebKit Commit Bot
Comment 7 2017-05-08 13:49:26 PDT
Comment on attachment 309398 [details] Patch Clearing flags on attachment: 309398 Committed r216451: <http://trac.webkit.org/changeset/216451>
WebKit Commit Bot
Comment 8 2017-05-08 13:49:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.