Bug 171697

Summary: REGRESSION(r216138): Web Inspector: ASSERT(!content.isNull()) when checking for source map url opening inspector
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix mattbaker: review+

Joseph Pecoraro
Reported 2017-05-04 15:45:25 PDT
Summary: ASSERT(!content.isNull()) when checking for source map url opening inspector Regressed with r216138 which returned String() instead of emptyString(). Steps to Reproduce: 1. Inspect netflix.com => ASSERT Crashes in Release: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 JSC::Yarr::interpret(JSC::Yarr::BytecodePattern*, WTF::String const&, unsigned int, unsigned int*) + 11 1 Inspector::ContentSearchUtilities::findStylesheetSourceMapURL(WTF::String const&) + 375 2 WebCore::InspectorPageAgent::sourceMapURLForResource(WebCore::CachedResource*) + 350 3 WebCore::InspectorPageAgent::buildObjectForFrameTree(WebCore::Frame*) + 988 4 non-virtual thunk to WebCore::InspectorPageAgent::getResourceTree(WTF::String&, WTF::RefPtr<Inspector::Protocol::Page::FrameResourceTree>&) + 33 5 Inspector::PageBackendDispatcher::getResourceTree(long, WTF::RefPtr<Inspector::InspectorObject>&&) + 93 6 Inspector::PageBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) + 570
Attachments
[PATCH] Proposed Fix (1.68 KB, patch)
2017-05-04 15:47 PDT, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-05-04 15:45:33 PDT
<rdar://problem/31999512>
Joseph Pecoraro
Comment 2 2017-05-04 15:47:29 PDT
Created attachment 309108 [details] [PATCH] Proposed Fix
Matt Baker
Comment 3 2017-05-04 15:56:55 PDT
Comment on attachment 309108 [details] [PATCH] Proposed Fix r=me
Blaze Burg
Comment 4 2017-05-04 15:59:23 PDT
Comment on attachment 309108 [details] [PATCH] Proposed Fix r=mews too
Joseph Pecoraro
Comment 5 2017-05-04 16:04:57 PDT
<https://trac.webkit.org/r216215>
Note You need to log in before you can comment on or make changes to this bug.