Bug 171669

Summary: CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, inspector-bugzilla-changes, joepeck, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mark.lam: review+

Blaze Burg
Reported 2017-05-04 09:52:03 PDT
Triggered by safaridriver's 'AutomaticInspection' capability after recent changes to add the interrupt dispatcher.
Attachments
Patch (2.70 KB, patch)
2017-05-04 09:58 PDT, Blaze Burg 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-05-04 09:52:22 PDT
<rdar://problem/31967684>
Blaze Burg
Comment 2 2017-05-04 09:58:10 PDT
Created attachment 309058 [details] Patch
Mark Lam
Comment 3 2017-05-04 10:07:52 PDT
Comment on attachment 309058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309058&action=review r=me with suggestion for improvement. > Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp:59 > + if (!WebCore::g_commonVMOrNull) While the global can be accessed directly (I suspect just for linkage purposes), I prefer it if you can introduce a WebCore::commonVMOrNull() inline function in CommonVM.h, and use that instead. I prefer that we don't encourage use of direct access to a global var.
Blaze Burg
Comment 4 2017-05-04 11:11:54 PDT
(In reply to Mark Lam from comment #3) > Comment on attachment 309058 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309058&action=review > > r=me with suggestion for improvement. > > > Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp:59 > > + if (!WebCore::g_commonVMOrNull) > > While the global can be accessed directly (I suspect just for linkage > purposes), I prefer it if you can introduce a WebCore::commonVMOrNull() > inline function in CommonVM.h, and use that instead. I prefer that we don't > encourage use of direct access to a global var. OK
Blaze Burg
Comment 5 2017-05-05 12:44:53 PDT
Committed r216263: <http://trac.webkit.org/changeset/216263>
Note You need to log in before you can comment on or make changes to this bug.