Bug 171668

Summary:

MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64

Product:

WebKit

Reporter:

Nael Ouedraogo <nael.ouedp>

Component:

Media

Assignee:

Nael Ouedraogo <nael.ouedp>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, jer.noble, rniwa, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Patch	none
Patch	none

Nael Ouedraogo

Reported 2017-05-04 09:34:46 PDT

MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64.

Attachments
Patch (13.93 KB, patch) 2017-05-04 09:50 PDT, Nael Ouedraogo	no flags	Details Formatted Diff Diff
Patch (16.97 KB, patch) 2017-05-29 09:16 PDT, Nael Ouedraogo	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (757.01 KB, application/zip) 2017-05-29 10:14 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (875.26 KB, application/zip) 2017-05-29 10:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.60 MB, application/zip) 2017-05-29 10:34 PDT, Build Bot	no flags	Details
Patch (19.39 KB, patch) 2017-05-30 06:38 PDT, Nael Ouedraogo	no flags	Details Formatted Diff Diff
Patch (18.93 KB, patch) 2017-06-13 10:08 PDT, Nael Ouedraogo	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Nael Ouedraogo

Comment 1 2017-05-04 09:50:01 PDT

Created attachment 309056 [details] Patch

Jer Noble

Comment 2 2017-05-09 10:35:54 PDT

Comment on attachment 309056 [details] Patch You can't just change the behavior of MediaTime (such as allowing it to represent double values > 2^64) without defining what happens with math operations between a rational MediaTime and a double outside 2^64. What does it mean to do `MediaTime(1,2) * MediaTime(1e303)`? Also, please add API tests to verify this new behavior.

Nael Ouedraogo

Comment 3 2017-05-29 09:16:42 PDT

Created attachment 311475 [details] Patch

Nael Ouedraogo

Comment 4 2017-05-29 09:33:32 PDT

Thanks for the comments. In uploaded patch, I modified MediaTime so that rational MediaTime is converted first to double for math operations between a rational and double MediaTime. The precision of `MediaTime(1,2) * MediaTime(1e303)` math operation is thus the same as for the double operation (`0.5f * 1e303`). I added new API tests to verify the new behavior.

Build Bot

Comment 5 2017-05-29 10:14:48 PDT

Comment on attachment 311475 [details] Patch Attachment 311475 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3837746 New failing tests: media/media-source/media-source-timeoffset.html

Build Bot

Comment 6 2017-05-29 10:14:50 PDT

Created attachment 311477 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-05-29 10:19:59 PDT

Comment on attachment 311475 [details] Patch Attachment 311475 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3837748 New failing tests: media/media-source/media-source-timeoffset.html

Build Bot

Comment 8 2017-05-29 10:20:00 PDT

Created attachment 311478 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-05-29 10:34:57 PDT

Comment on attachment 311475 [details] Patch Attachment 311475 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3837753 New failing tests: media/media-source/media-source-timeoffset.html

Build Bot

Comment 10 2017-05-29 10:34:58 PDT

Created attachment 311479 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Nael Ouedraogo

Comment 11 2017-05-30 06:38:10 PDT

Created attachment 311502 [details] Patch

Nael Ouedraogo

Comment 12 2017-06-13 10:08:49 PDT

Created attachment 312783 [details] Patch

Nael Ouedraogo

Comment 13 2017-06-14 01:14:24 PDT

Thanks for the review.

WebKit Commit Bot

Comment 14 2017-06-14 01:44:33 PDT

Comment on attachment 312783 [details] Patch Clearing flags on attachment: 312783 Committed r218247: <http://trac.webkit.org/changeset/218247>

WebKit Commit Bot

Comment 15 2017-06-14 01:44:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.