Bug 171649 – [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adrian Perez]

Users with glibc version 2.25 or newer will find this build issue when
using “update-webkitgtk-libs” to build dependencies using JHBuild:

 …/WebKit/WebKitBuild/DependenciesGTK/Source/fontconfig-2.11.1/src/fcmatch.c:284:63:
   error: 'PRI_CHAR_WIDTH_STRONG' undeclared here (not in a function)
     #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
                                                                   ^
 …/WebKit/WebKitBuild/DependenciesGTK/Source/fontconfig-2.11.1/src/fcobjs.h:54:1:
   note: in expansion of macro 'FC_OBJECT'
     FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
     ^~~~~~~~~
 …/WebKit/WebKitBuild/DependenciesGTK/Source/fontconfig-2.11.1/src/fcmatch.c:284:84:
   error: 'PRI_CHAR_WIDTH_WEAK' undeclared here (not in a function)
     #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
                                                                                        ^
 …/WebKit/WebKitBuild/DependenciesGTK/Source/fontconfig-2.11.1/src/fcobjs.h:54:1:
   note: in expansion of macro 'FC_OBJECT'
     FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
     ^~~~~~~~~

This has been already solved in Fontconfig a few months ago in this commit

  https://cgit.freedesktop.org/fontconfig/commit/?id=1ab5258f7c2abfafcd63a760ca08bf93591912da

I will be posting a patch which adds this commit as a patch under “Tools/gtk/patches/”
to be applied by JHBuild when it builds Fontconfig.

[Adrian Perez]

Also, gperf 3.1+ makes the Fontconfig build choke, see:

  https://cgit.freedesktop.org/fontconfig/commit/?id=9878b306f6c673d3d6cd9db487f67eb426cc03df

I am trying to also add that one.

[Adrian Perez]

Created attachment 309040 [details]
Patch

[Adrian Perez]

Created attachment 309041 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 309041 [details]
Patch

Clearing flags on attachment: 309041

Committed r216184: <http://trac.webkit.org/changeset/216184>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.