Bug 171631

Summary:

[Cocoa] Stop exporting symbols for ivars that were made private

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKit Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, joepeck, mitz

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=171208

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2017-05-03 16:21:01 PDT

Stop exporting symbols for ivars that were made private. Bug 171208: <https://trac.webkit.org/r215685> made all of these ivars private, so they should not need to be exported anymore.

Attachments
[PATCH] Proposed Fix (1.62 KB, patch) 2017-05-03 16:21 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-05-03 16:21:47 PDT

Created attachment 308980 [details] [PATCH] Proposed Fix

Aakash Jain

Comment 2 2017-05-03 16:28:31 PDT

looks fine to me. but probably mitz should review as well.

WebKit Commit Bot

Comment 3 2017-05-03 18:37:48 PDT

Comment on attachment 308980 [details] [PATCH] Proposed Fix Clearing flags on attachment: 308980 Committed r216165: <http://trac.webkit.org/changeset/216165>

WebKit Commit Bot

Comment 4 2017-05-03 18:37:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.