Bug 171587

Summary: Web Inspector: 404 Image Load does not appear as a failure in Web Inspector
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2017-05-02 18:09:10 PDT 
404 Image Load does not appear as a failure in Web Inspector

Test:
<img src="DOES-NOT-EXIST.png">

Steps to Reproduce:
1. Inspect tests page
  => Expected "DOES-NOT-EXIST.png" to be red in the Resources tab sidebar
2. Show Network Tab and Reload
  => Expected "DOES-NOT-EXIST.png to be red in the Network tab sidebar
3. Select the resource to show contents
  => Expected error message

Notes:
• WebCore attempts to decode data from a 404 response, in this case it is the HTML 404 Not Found response which produces a decode error.
Comment 1 Joseph Pecoraro 2017-05-02 18:09:18 PDT 
<rdar://problem/13222846>
Comment 2 Joseph Pecoraro 2017-05-02 18:14:45 PDT 
Created attachment 308874 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2017-05-03 13:07:19 PDT 
Comment on attachment 308874 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=308874&action=review

r=me

> Source/WebCore/ChangeLog:13
> +        Inline the function to make this less confusing.

This is much clearer now, nice change.
Comment 4 WebKit Commit Bot 2017-05-03 13:36:31 PDT 
Comment on attachment 308874 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308874

Committed r216138: <http://trac.webkit.org/changeset/216138>
Comment 5 WebKit Commit Bot 2017-05-03 13:36:33 PDT 
All reviewed patches have been landed.  Closing bug.