Bug 171525

Summary: Eliminate ?pipe=sub from Resource Timing Tests
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Page LoadingAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, joepeck, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-05-01 17:11:03 PDT
Eliminate ?pipe=sub from Resource Timing Tests Files can just be named "foo.sub.js" and get the substitutions.
Attachments
[PATCH] Proposed Fix (21.80 KB, patch)
2017-05-01 17:12 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-05-01 17:12:11 PDT
Created attachment 308790 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2017-05-01 18:24:23 PDT
Comment on attachment 308790 [details] [PATCH] Proposed Fix Clearing flags on attachment: 308790 Committed r216052: <http://trac.webkit.org/changeset/216052>
WebKit Commit Bot
Comment 3 2017-05-01 18:24:24 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2017-05-01 21:33:40 PDT
What is the magic that performs substitutions on files named like that? I don't think that it's a common behavior on the web. Also, will the changes get lost on the next reimport?
youenn fablet
Comment 5 2017-05-01 22:18:30 PDT
(In reply to Alexey Proskuryakov from comment #4) > What is the magic that performs substitutions on files named like that? I > don't think that it's a common behavior on the web. wpt server is doing it. This is the usual way of doing it in wpt > Also, will the changes get lost on the next reimport? These should be upstreamed to wpt asap
Note You need to log in before you can comment on or make changes to this bug.