Summary: | [Cocoa] Replace uses of [get…() alloc] with alloc…Instance() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | New Bugs | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, buildbot, commit-queue, ggaren | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2017-04-30 13:14:15 PDT
Created attachment 308699 [details]
Use the safer idiom
Attachment 308699 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:51: Missing spaces around : [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:56: Missing spaces around : [whitespace/init] [4]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 308699 [details] Use the safer idiom View in context: https://bugs.webkit.org/attachment.cgi?id=308699&action=review r=me > Source/WebCore/ChangeLog:3 > + [Cocoa] Replaces uses of [getâ¦() alloc] with allocâ¦Instance() I think you meant "get...Class()". (In reply to Geoffrey Garen from comment #3) > Comment on attachment 308699 [details] > Use the safer idiom > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308699&action=review > > r=me Thanks! > > > Source/WebCore/ChangeLog:3 > > + [Cocoa] Replaces uses of [getâ¦() alloc] with allocâ¦Instance() > > I think you meant "get...Class()". I think you meant to comment in bug 75394 :) Comment on attachment 308699 [details] Use the safer idiom Clearing flags on attachment: 308699 Committed r215992: <http://trac.webkit.org/changeset/215992> All reviewed patches have been landed. Closing bug. (In reply to WebKit Commit Bot from comment #5) > Comment on attachment 308699 [details] > Use the safer idiom > > Clearing flags on attachment: 308699 > > Committed r215992: <http://trac.webkit.org/changeset/215992> Tried to fix the iOS build in <https://trac.webkit.org/r215993>. (In reply to mitz from comment #7) > (In reply to WebKit Commit Bot from comment #5) > > Comment on attachment 308699 [details] > > Use the safer idiom > > > > Clearing flags on attachment: 308699 > > > > Committed r215992: <http://trac.webkit.org/changeset/215992> > > Tried to fix the iOS build in <https://trac.webkit.org/r215993>. And again in <https://trac.webkit.org/r215995>. > > > Source/WebCore/ChangeLog:3
> > > + [Cocoa] Replaces uses of [getâ¦() alloc] with allocâ¦Instance()
> >
> > I think you meant "get...Class()".
>
> I think you meant to comment in bug 75394 :)
Heh, I was trying to call attention to the missing word "Class" rather than the rendering of "...".
(In reply to Geoffrey Garen from comment #9) > > > > Source/WebCore/ChangeLog:3 > > > > + [Cocoa] Replaces uses of [getâ¦() alloc] with allocâ¦Instance() > > > > > > I think you meant "get...Class()". > > > > I think you meant to comment in bug 75394 :) > > Heh, I was trying to call attention to the missing word "Class" rather than > the rendering of "...". 😮 |