Bug 171478

Summary: [Xcode] libwebrtc SRCROOT includes examples
Product: WebKit Reporter: mitz
Component: WebCore Misc.Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: jmarcell, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=270747
Attachments:
Description Flags
Exclude examples from installsrc thorton: review+

mitz
Reported 2017-04-29 09:34:07 PDT
The libwebrtc SRCROOT includes content from Source/webrtc/examples, some of the which is incompatible with Apple’s build system. Since the examples subdirectory is not used in building any of the targets in the Xcode project, it can be safely excluded from SRCROOT. Patch forthcoming.
Attachments
Exclude examples from installsrc (1.41 KB, patch)
2017-04-29 09:35 PDT, mitz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2017-04-29 09:35:59 PDT
Created attachment 308670 [details] Exclude examples from installsrc
Radar WebKit Bug Importer
Comment 2 2017-04-29 10:41:08 PDT
<rdar://problem/31905250>
mitz
Comment 3 2017-04-29 11:33:23 PDT
Fixed in <https://trac.webkit.org/r215974>.
Note You need to log in before you can comment on or make changes to this bug.