Summary: | Speedometer: Add an Elm TodoMVC implementation | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Addy Osmani <addyo> | ||||||||
Component: | Tools / Tests | Assignee: | Addy Osmani <addyo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cdumez, lforschler, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 170513 | ||||||||||
Attachments: |
|
Description
Addy Osmani
2017-04-28 17:04:51 PDT
Created attachment 308622 [details]
Patch
Created attachment 308629 [details]
Patch
Comment on attachment 308629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308629&action=review > PerformanceTests/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + Speedometer: Add Elm TodoMVC implementation Same comment about the blank line and inline comments. This patch also doesn't seem to apply on ToT for whatever reason. Created attachment 309848 [details]
Patch
I've corrected the blank line and inline comments. Keeping fingers crossed on ToT this time :) Comment on attachment 309848 [details] Patch Clearing flags on attachment: 309848 Committed r216717: <http://trac.webkit.org/changeset/216717> All reviewed patches have been landed. Closing bug. |