Bug 17144

Summary: RenderReplaced initializes size to invalid arbitrary value
Product: WebKit Reporter: Rodney Dawes <dobey>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch to initialize RenderReplaced size to 0,0 hyatt: review-

Rodney Dawes
Reported 2008-02-01 14:44:02 PST
RenderReplaced initializes m_intrinsicSize to an invalid arbitrary value, which causes rendering and layout problems with windowless plug-ins that may only provide scripting functionality. The attached patch changes this initialization to 0,0 instead of the arbitrary 300,150 values.
Attachments
Patch to initialize RenderReplaced size to 0,0 (1.33 KB, patch)
2008-02-01 14:44 PST, Rodney Dawes 		hyatt: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rodney Dawes
Comment 1 2008-02-01 14:44:36 PST
Created attachment 18854 [details] Patch to initialize RenderReplaced size to 0,0
Dave Hyatt
Comment 2 2008-02-01 14:47:40 PST
Comment on attachment 18854 [details] Patch to initialize RenderReplaced size to 0,0 300x150 is the specified intrinsic size for plugins. There may be a bug here still, but I think you will create compatibility problems if you change this to 0,0.
Rodney Dawes
Comment 3 2008-02-01 15:12:12 PST
(In reply to comment #2) > (From update of attachment 18854 [details] [edit]) > 300x150 is the specified intrinsic size for plugins. There may be a bug here > still, but I think you will create compatibility problems if you change this to > 0,0. Specified where?
Nikolas Zimmermann
Comment 5 2011-06-09 12:22:19 PDT
Closing this bug as invalid, the 300x150 default intrinsic size is correct, per spec. It is only used at all _if_ computeReplacedLogicalWidth/Height fallsback to the default intrinsic size.
Note You need to log in before you can comment on or make changes to this bug.