Bug 171407

Summary: RealtimeMediaSourceCenter callbacks should be passed as r-values
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixing gtk build
none
Patch for landing none

Description youenn fablet 2017-04-27 16:50:14 PDT 
They are passed by value currently
Comment 1 youenn fablet 2017-04-27 16:51:16 PDT 
Created attachment 308477 [details]
Patch
Comment 2 youenn fablet 2017-04-28 10:24:42 PDT 
Created attachment 308551 [details]
Fixing gtk build
Comment 3 youenn fablet 2017-05-05 23:29:29 PDT 
Created attachment 309273 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-05-06 00:22:40 PDT 
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]:

The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-05-06 00:23:08 PDT 
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]:

http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2017-05-06 01:02:40 PDT 
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]:

http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-05-06 01:02:41 PDT 
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]:

The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2017-05-06 01:56:02 PDT 
Comment on attachment 309273 [details]
Patch for landing

Clearing flags on attachment: 309273

Committed r216323: <http://trac.webkit.org/changeset/216323>
Comment 9 WebKit Commit Bot 2017-05-06 01:56:04 PDT 
All reviewed patches have been landed.  Closing bug.