| Summary: | Add support for height property on <tbody> element | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Walters <mikel.walters> | ||||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | bfulgham, hyatt, jamie.pate, jornh, mikel.walters, mitz, phiw2, posenato, rendezvouscp, webkit, webkit-bug-importer, webkit | ||||||||
| Priority: | P3 | Keywords: | HasReduction, InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | 3239 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 18932 [details] Test case Firefox respects the height given to tbody while nightly r29955 does not (confirmed). Created attachment 18954 [details]
Test case
Improved test case.
Correct result exampel: tbody = 100px row1 = 25px row2 = 50px row3 = 75px <-- I meant for this to be 25px *** Bug 13017 has been marked as a duplicate of this bug. *** Created attachment 21071 [details]
Patch
This patch fix the attached test case (but contrary to the previous comments, the test case has 4 rows, doesn't it?)
Comment on attachment 21071 [details]
Patch
+ int ch = max(m_grid[r].height.calcMinValue(0), style()->height().calcMinValue(0) / m_gridRows);
Looks like the row heights may not add up to the section height due to rounding.
Comment on attachment 21071 [details]
Patch
This seems wrong. It assumes that the height of the <tbody> can be evenly divided by the number of rows. That's clearly not correct when some rows have explicit heights themselves. For example, consider a <tbody> with a height of 100px, containing five rows where the first four rows all are 10px tall. It doesn't make sense to have the fifth row by 20px tall. It should be 60px tall.
We'll need more than one test case for this, too. The test patch needs to include the expected results for the test case. Does this change affect the results of any other test cases? I'd be amazed if it didn't affect any of the hundreds of table test cases we imported from the Mozilla project.
I want to hear Hyatt's take on this too. What is the correct behavior for table sections?
WebKit still fails this test. |
tbody works as it should in firefox... IE works but now how expected tbody.myCss { height: 100px; } This should result in the tbody (including all subsequent rows together) to be 100px. IE does not impliment this correctly and results in every subsequent row height = 100px. Very bad. Correct result exampel: tbody = 100px row1 = 25px row2 = 50px row3 = 75px