Bug 171379

Summary: Use text-shadow to visualize simple line layout coverage.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
before
none
after
none
Patch none

zalan
Reported 2017-04-27 09:16:10 PDT
Instead of the green borders. It's way more subtle (for everyday use).
Attachments
before (1.24 MB, image/png)
2017-04-27 09:19 PDT, zalan 		no flags
Details
after (1.84 MB, image/png)
2017-04-27 09:20 PDT, zalan 		no flags
Details
Patch (5.48 KB, patch)
2017-04-27 09:24 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-04-27 09:19:55 PDT
Created attachment 308396 [details] before
zalan
Comment 2 2017-04-27 09:20:14 PDT
Created attachment 308397 [details] after
zalan
Comment 3 2017-04-27 09:24:36 PDT
Created attachment 308398 [details] Patch
Antti Koivisto
Comment 4 2017-04-27 09:35:46 PDT
Beautiful! r=me
Antti Koivisto
Comment 5 2017-04-27 09:41:52 PDT
All the everyday simple line layout border users are going to love this.
WebKit Commit Bot
Comment 6 2017-04-27 10:11:41 PDT
Comment on attachment 308398 [details] Patch Clearing flags on attachment: 308398 Committed r215878: <http://trac.webkit.org/changeset/215878>
WebKit Commit Bot
Comment 7 2017-04-27 10:11:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.