Bug 171371

Summary:

Repeated layouts in Mail due to viewport units being used with auto-sizing

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, mitz, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	zalan: review+
patch	none
patch	commit-queue: commit-queue-
patch	commit-queue: commit-queue-
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan	none
patch	none

Antti Koivisto

Reported 2017-04-27 03:10:05 PDT

We leave layout with unclean style.

Attachments
patch (3.90 KB, patch) 2017-04-27 03:18 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (3.53 KB, patch) 2017-04-27 03:36 PDT, Antti Koivisto	zalan: review+	Details Formatted Diff Diff
patch (4.31 KB, patch) 2017-04-27 04:21 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (4.85 KB, patch) 2017-04-27 05:28 PDT, Antti Koivisto	commit-queue: commit-queue-	Details Formatted Diff Diff
patch (4.09 KB, patch) 2017-04-27 05:48 PDT, Antti Koivisto	commit-queue: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan (294.86 KB, application/zip) 2017-04-27 06:35 PDT, WebKit Commit Bot	no flags	Details
patch (4.87 KB, patch) 2017-04-27 06:57 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-04-27 03:16:49 PDT

<rdar://problem/28780084>

Antti Koivisto

Comment 2 2017-04-27 03:18:28 PDT

Created attachment 308369 [details] patch

Antti Koivisto

Comment 3 2017-04-27 03:36:05 PDT

Created attachment 308370 [details] patch

Antti Koivisto

Comment 4 2017-04-27 04:21:00 PDT

Created attachment 308373 [details] patch

Antti Koivisto

Comment 5 2017-04-27 05:28:46 PDT

Created attachment 308380 [details] patch

WebKit Commit Bot

Comment 6 2017-04-27 05:29:24 PDT

Comment on attachment 308380 [details] patch Rejecting attachment 308380 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 308380, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: size-expected.html patching file LayoutTests/css3/viewport-percentage-lengths/vh-auto-size.html patching file LayoutTests/platform/ios/TestExpectations Hunk #1 FAILED at 2940. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/ios/TestExpectations.rej patching file LayoutTests/platform/mac-wk1/TestExpectations Hunk #1 succeeded at 359 (offset -1 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3619044

Antti Koivisto

Comment 7 2017-04-27 05:48:39 PDT

Created attachment 308382 [details] patch

WebKit Commit Bot

Comment 8 2017-04-27 06:35:05 PDT

Comment on attachment 308382 [details] patch Rejecting attachment 308382 [details] from commit-queue. Number of test failures exceeded the failure limit. Full output: http://webkit-queues.webkit.org/results/3619359

WebKit Commit Bot

Comment 9 2017-04-27 06:35:06 PDT

Created attachment 308385 [details] Archive of layout-test-results from webkit-cq-03 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 10 2017-04-27 06:57:08 PDT

Created attachment 308387 [details] patch

WebKit Commit Bot

Comment 11 2017-04-27 09:51:14 PDT

Comment on attachment 308387 [details] patch Clearing flags on attachment: 308387 Committed r215874: <http://trac.webkit.org/changeset/215874>

WebKit Commit Bot

Comment 12 2017-04-27 09:51:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.