Summary: | Web Inspector: ASSERT(!m_startedComposite) fails when recording on non-Cocoa Timeline | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, Hironori.Fujii, inspector-bugzilla-changes, mattbaker | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Ross Kirsling
2017-04-26 20:04:10 PDT
Compositing events are Cocoa-specific until we have platform abstraction for RunLoopObserver: https://bugs.webkit.org/show_bug.cgi?id=142748 Therefore we should simply guard the willComposite callsite for now. Created attachment 308327 [details]
Patch
I'd like Matt to review this when he's back in office next week. Comment on attachment 308327 [details]
Patch
r=me.
I don't have an easy way to test this, but it seems clear that the second time willComposite is called (and every time after) it will assert, since didComposite is never called. Ross's patch matches the guards around the creation of the run loop observation points and looks correct.
Comment on attachment 308327 [details] Patch Clearing flags on attachment: 308327 Committed r216043: <http://trac.webkit.org/changeset/216043> All reviewed patches have been landed. Closing bug. |