Bug 171338

Summary:

RTL: recent searches popover is displayed in incorrect location

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, dino, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2017-04-26 13:19:53 PDT

rdar://problem/31377807

Comment 1 zalan 2017-04-26 13:27:04 PDT

Created attachment 308279 [details]
Patch

Comment 2 WebKit Commit Bot 2017-04-26 13:52:18 PDT

Comment on attachment 308279 [details]
Patch

Clearing flags on attachment: 308279

Committed r215830: <http://trac.webkit.org/changeset/215830>

Comment 3 WebKit Commit Bot 2017-04-26 13:52:20 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Simon Fraser (smfr) 2017-04-26 14:56:48 PDT

Comment on attachment 308279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308279&action=review

> Source/WebCore/rendering/RenderSearchField.cpp:138
> +    FloatPoint absTopLeft = localToAbsolute(FloatPoint(), UseTransforms);
> +    IntRect absBounds = absoluteBoundingBoxRectIgnoringTransforms();

This is pretty confusing. Why ignore transforms for one but not the other?

Did you test iframes?