Bug 171328

Summary: [macOS] Add picture-in-picture support to WebPlaybackControlsManager
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, buildbot, commit-queue, eric.carlson, jer.noble, mitz, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2017-04-26 09:18:27 PDT
[macOS] Add picture-in-picture support to WebPlaybackControlsManager
Attachments
Patch (16.17 KB, patch)
2017-04-26 09:30 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (16.89 KB, patch)
2017-04-26 09:38 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-04-26 09:20:24 PDT
rdar://problem/29875010
Andy Estes
Comment 2 2017-04-26 09:30:13 PDT
Created attachment 308257 [details] Patch
Build Bot
Comment 3 2017-04-26 09:31:47 PDT
Attachment 308257 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/AVKitSPI.h:216: Should not have spaces around = in property attributes. [whitespace/property] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 4 2017-04-26 09:38:39 PDT
Created attachment 308258 [details] Patch
WebKit Commit Bot
Comment 5 2017-04-26 10:51:55 PDT
Comment on attachment 308258 [details] Patch Clearing flags on attachment: 308258 Committed r215811: <http://trac.webkit.org/changeset/215811>
WebKit Commit Bot
Comment 6 2017-04-26 10:51:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.