Bug 171313

Summary:

Re-sync html/browsers/the-window-object web-platform-tests from upstream

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, lforschler, rniwa, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

170548

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Patch	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-04-25 20:46:01 PDT

Re-sync html/browsers/the-window-object web-platform-tests from upstream.

Attachments
Patch (124.33 KB, patch) 2017-04-25 20:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (834.74 KB, application/zip) 2017-04-25 21:56 PDT, Build Bot	no flags	Details
Patch (133.25 KB, patch) 2017-04-25 22:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (17.46 MB, application/zip) 2017-04-26 00:00 PDT, Build Bot	no flags	Details
Patch (165.27 KB, patch) 2017-04-26 10:10 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (177.66 KB, patch) 2017-04-26 12:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-04-25 20:49:08 PDT

Created attachment 308203 [details] Patch

Build Bot

Comment 2 2017-04-25 21:56:07 PDT

Comment on attachment 308203 [details] Patch Attachment 308203 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3607380 New failing tests: imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-top.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screeny.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-top-left.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-left.html

Build Bot

Comment 3 2017-04-25 21:56:08 PDT

Created attachment 308213 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Chris Dumez

Comment 4 2017-04-25 22:16:22 PDT

Created attachment 308215 [details] Patch

youenn fablet

Comment 5 2017-04-25 22:20:06 PDT

> LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log:-26 > -/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-001.html With this patch, this file is removed from the commit log but not from the WebKit repo apparently. It might be the test importer is broken here. Just checking, we have no unit test for that... Can you check whether we should remove it and update the patch accordingly?

Build Bot

Comment 6 2017-04-26 00:00:10 PDT

Comment on attachment 308215 [details] Patch Attachment 308215 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3607858 New failing tests: imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerheight.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-screenx-screeny.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-top.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-width-height.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-top-left.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-width.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-innerheight-innerwidth.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screeny.html imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-left.html

Build Bot

Comment 7 2017-04-26 00:00:12 PDT

Created attachment 308224 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Chris Dumez

Comment 8 2017-04-26 10:10:50 PDT

Created attachment 308263 [details] Patch

youenn fablet

Comment 9 2017-04-26 11:14:28 PDT

Let's remove open-features-tokenization-001.html first.

Chris Dumez

Comment 10 2017-04-26 12:36:27 PDT

Created attachment 308275 [details] Patch

Chris Dumez

Comment 11 2017-04-26 12:39:00 PDT

Comment on attachment 308275 [details] Patch Clearing flags on attachment: 308275 Committed r215822: <http://trac.webkit.org/changeset/215822>

Chris Dumez

Comment 12 2017-04-26 12:39:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.