Bug 171312

Summary: Web Inspector: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception)
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2017-04-25 20:44:48 PDT 
Summary:
Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception)

Steps to Reproduce:
1. Inspect this page
2. Show Network Tab
3. Reload
4. Show Priority Column if it is not visible
5. Sort by Priority Column
  => all rows disappear

Exception:
TypeError:​ Cannot convert a symbol to a number (at TimelineDataGrid.js:​411:​17)​
    _sortComparator @ TimelineDataGrid.js:​411:​17
    _sortComparator @ [native code]​
    merge @ [native code]​
    mergeSort @ [native code]​
    comparatorSort @ [native code]​
    sort @ [native code]​
    _sort @ TimelineDataGrid.js:​336:​36
    dispatch @ Object.js:​170:​30
Comment 1 Joseph Pecoraro 2017-04-25 20:45:00 PDT 
<rdar://problem/31828554>
Comment 2 Joseph Pecoraro 2017-04-25 20:46:13 PDT 
Created attachment 308202 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2017-04-25 23:06:48 PDT 
Comment on attachment 308202 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-04-25 23:35:08 PDT 
Comment on attachment 308202 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308202

Committed r215793: <http://trac.webkit.org/changeset/215793>
Comment 5 WebKit Commit Bot 2017-04-25 23:35:09 PDT 
All reviewed patches have been landed.  Closing bug.