Bug 171307

Summary: Speedometer: Update the AngularJS implementation to a more recent library version
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172077
Bug Depends on:    
Bug Blocks: 170513    
Description Flags
Patch none

Description Addy Osmani 2017-04-25 18:28:57 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), the AngularJS (1.x) implementation of TodoMVC needs to be updated to a more recent version.
Comment 1 Addy Osmani 2017-04-25 18:42:01 PDT
Created attachment 308184 [details]
Comment 2 Ryosuke Niwa 2017-05-09 14:45:55 PDT
Comment on attachment 308184 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=308184&action=review

> PerformanceTests/ChangeLog:7
> +        Updates the AngularJS implementation of TodoMVC to 1.4.x

Add a blank line above this line.

> PerformanceTests/ChangeLog:49
> +        (isValidDottedPath):

Please remove these inline comments when files are just imported from somewhere.
Comment 3 Addy Osmani 2017-05-11 16:19:14 PDT
Created attachment 309813 [details]
Comment 4 Addy Osmani 2017-05-11 16:21:13 PDT
Added a blank line above 7 and removed inline comments from the changelog. PTAL.
Comment 5 WebKit Commit Bot 2017-05-11 17:12:28 PDT
Comment on attachment 309813 [details]

Clearing flags on attachment: 309813

Committed r216706: <http://trac.webkit.org/changeset/216706>
Comment 6 WebKit Commit Bot 2017-05-11 17:12:30 PDT
All reviewed patches have been landed.  Closing bug.